astral-sh/ruff

Odd ecosystem results on typeshed

Open

#11,305 opened on May 6, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (47,527 stars) (2,088 forks)batch import
cihelp wanted

Description

Seems like there's something up with the ecosystem check when it runs on typeshed currently. We've had issues on several PRs where the ecosystem check has produced surprising results that don't make logical sense and can't be reproduced locally:

No idea what's up here

Contributor guide

Tech stack
pythonrust
Domain
ci cdtesting
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
unclear
Prerequisites
Ruff CI pipelinetypeshedPythonGitHub Actions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate the ecosystem check in the ruff repository, particularly the CI configuration and the check logic. Review the linked PRs (#11128, #11269, #10779) to understand the surprising results. Look at the typeshed repository and how the ecosystem check interacts with it. Identify why results are not reproducible locally and suggest improvements to the check process.