assisrafael/angular-input-masks

For a large numbers the parser function in Number.js is causing it to round to very huge different value.

Open

#158 opened on Feb 5, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (970 stars) (334 forks)batch import
enhancementhelp wanted

Description

To be detail when a large number is entered in to the input field like 9,223,372,036,854,775,295.99 the model value is being rounded in a way it is very different number from what a actual input is and this is because of the parseFloat in parser function in Number.js. Im talking about this line below without the parseFloat the modelValue is correct but with that it will effect for large input values like above. "var actualNumber = parseFloat(modelMask.apply(valueToFormat));"

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptunderstanding of floating point precisionAngularJS basic knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The bug is in the file Number.js at the line containing 'var actualNumber = parseFloat(modelMask.apply(valueToFormat));'. The parseFloat function loses precision for large numbers (e.g., 9,223,372,036,854,775,295.99). To fix, consider using a library like BigNumber.js or implementing a string based parser that preserves the full number without rounding. Check if there are any existing PRs or forks that address this, and test with edge cases of large numbers and decimal places.