Update unit test to avoid deprecated `ExpectedException.none()` by using `Assert.assertThrows()`
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Search the repository for ExpectedException.none(), expectIllegalStateIsNotShowingComponent, and expectIllegalStateIsDisabledComponent to identify all affected unit tests and helpers. Run the relevant unit-test suite before and after the replacements; done means the deprecated usages are removed and the tests retain their existing exception and message assertions.
Written by the indexing model from the issue text.
Description
ExpectedException.none() is marked as deprecated but there are so many unit tests which depends on the function.
These cases can be rewritten by using Assert.assertThrows(Class<?> class, ThrowableRunnable run)
There are also Similar deprecation; expectIllegalStateIsNotShowingComponent and expectIllegalStateIsDisabledComponent
These can be implemented as like as followings;
public static AbstractStringAssert<?> assertThatIllegalStateExceptionCauseIsDisabledComponent(ThrowingRunnable r) {
Throwable t = Assert.assertThrows(IllegalStateException.class, r);
return assertThat(t.getMessage()).contains("Expecting component").contains("to be enabled");
}
public static AbstractStringAssert<?> assertThatIllegalStateExceptionCauseIsNotShowingComponent(ThrowingRunnable r) {
Throwable t = Assert.assertThrows(IllegalStateException.class, r);
return assertThat(t.getMessage()).contains("Expecting component").contains("to be shown on the screen");
}
public static AbstractStringAssert<?> assertThatIllegalStateExceptionCauseIsNotResizableComponent(ThrowingRunnable runnable) {
Throwable t = Assert.assertThrows(IllegalStateException.class, runnable);
return assertThat(t.getMessage()).contains("Expecting component").contains("to be resizable by the user");
}
- Dominant language
- Java
- Stars
- 121
- Forks
- 52
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from assertj/assertj-swing
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
assertj/assertj-swing#279 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
assertj/assertj-swing#278 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
assertj/assertj-swing#276 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
assertj/assertj-swing#277 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
assertj/assertj-swing#274 · 2 comments ·
All issues in assertj/assertj-swing
Similar issues
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
inu-appcenter/memorIN-backend#288 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
frontend maui-pilot pilot-ask question
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
area/plugin
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
kestra-io/plugin-kestra#190 ·