Generated assertions do not preserve generic types

Open
#92 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
java
Domain
tooling

Research direction

Start by reproducing the issue with a field declared as Optional and inspect the generator path that derives assertion method parameters from field types. Done means the generated hasFoo parameter preserves the generic type, producing Optional rather than raw Optional; add or update coverage for this example if the project has a relevant generator test.

Written by the indexing model from the issue text.

Description

generics

For example, if I have:
public final Optional<Boolean> foo;,

the generated assertion is:
hasFoo(java.util.Optional foo)

when it should be:
hasFoo(java.util.Optional<Boolean> foo)

Dominant language
Java
Stars
72
Forks
47
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from assertj/assertj-generator

All issues in assertj/assertj-generator

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.