Support Java 8 Optional Feature

Open
#51 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
java
Domain
tooling

Research direction

No source file or test is named in the issue. Start by locating the generator entry point that handles getter return types and generic types, then compare its output for the provided Person model. Done means Optional getters produce the requested assertion overloads with the intended String and Optional parameters.

Written by the indexing model from the issue text.

Description

Is it possible to support Java 8 Optional feature for the generator?

Sample model class:

public class Person {

    private String name;

    public Person(String name) {
        this.name = name;
    }

    public Optional<String> getName() {
        return name == null ? Optional.empty() : Optional.of(name);
    }
}

Generated assertion class:

public class PersonAssert extends AbstractAssert<PersonAssert, Person> {

  public PersonAssert hasName(java.util.Optional name) {
  }
}

Suggested assert class:

public class PersonAssert extends AbstractAssert<PersonAssert, Person> {

 // Generator might lookup generic type of the Optional and generate the method without Optional parameter
  public PersonAssert hasName(String name) {
  }

  public PersonAssert hasName(java.util.Optional name) {
  }
}
Dominant language
Java
Stars
72
Forks
47
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from assertj/assertj-generator

All issues in assertj/assertj-generator

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.