For boolean properties, support "hasPropertyName(boolean expectedValue)"
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start by locating the assertion generator logic that creates methods for boolean properties, then compare the requested API with the existing BooleanAssert pattern. Decide whether the generated method should be hasHideLegend(boolean) or equality-specific variants, and add coverage showing the generated assertion handles both expected boolean values.
Written by the indexing model from the issue text.
Description
Currently if a class has a boolean field / property (say hideLegend, the assertion generator produces two methods: isHideLegend() and isNotHideLegend. It would be really helpful to have an additional method hasHideLegend(boolean expectedValue). To keep with the BooleanAssert pattern, this might become hasHideLegendEqualTo(boolean) and hasHideLegendNotEqualTo(boolean). This is demonstrated by the example below:
private void testHelperMethod(MyAssertionClass instanceUnderTest, SomeInput input){
boolean expectedHasLegend = // some code that uses input to determine expected legend;
MyAssertionClassAssert assert = Assertions.assertThat(instanceUnderTest);
if (expectedHadLengeng)
assert.isHideLegend();
else
assert.isNotHideLegend();
}
The above could become:
private void testHelperMethod(MyAssertionClass instanceUnderTest, SomeInput input){
boolean expectedHasLegend = // some code that uses input to determine expected legend;
Assertions.assertThat(instanceUnderTest)
hasHideLegend(expectedHasLegend );
}
- Dominant language
- Java
- Stars
- 72
- Forks
- 47
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from assertj/assertj-generator
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
assertj/assertj-generator#278 ·
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
assertj/assertj-generator#220 ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
assertj/assertj-generator#219 ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
assertj/assertj-generator#204 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
assertj/assertj-generator#197 · 7 comments ·
All issues in assertj/assertj-generator
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
infinispan/infinispan#18150 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
opensearch-project/k-NN#3597 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100