(invisible) HTTPS_PROXY settings overrule explicit HTTP_PROXY settings
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- csharp
- Domain
- networking, tooling
Research direction
Start in ProxySettings.cs at private IWebProxy TryConfigureProxy(), especially the line checking _settings for the proxy setting name. Reproduce with https_proxy set without credentials alongside http_proxy and its credentials, then run libman restore. Done means explicit HTTP proxy credentials are honored and restore no longer produces the reported provider resolution errors.
Written by the indexing model from the issue text.
Description
Functional impact
If You configure only http_proxy + http_proxy.user + http_proxy.password, but the program gets a https_proxy URL from somewhere, Your settings will never be used and the restore function fails despite entering the right values.
I don't know how, but when debugging ProxySettings.cs, private IWebProxy TryConfigureProxy(), the line
if (_settings.TryGetValue(proxySettingName, out string proxyAddress)) (line 82)
returned a valid URL for https_proxy, even if it wasn't configured.
Therefore my own credentials were never used.
Minimal repro steps
-
configure:
https_proxy (with no credentials)
http_proxy
http_proxy.user
http_proxy.password -
Execute
libman restore -
You will get lots of errors, like
[LIB002]: The "jquery-easing@1.4.1" library could not be resolved by the "cdnjs" provider
Expected result
I would expect that the credentials I entered would make restore possible
I can understand that not every proxy needs user name + password
It would help, if at least in the documentation, the user would be instructed to set https_proxy + credentials first.
Unfortunately, the current documentation only mentions http_proxy settings.
- Dominant language
- C#
- Stars
- 486
- Forks
- 91
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from aspnet/LibraryManager
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
aspnet/LibraryManager#824 · 1 comment · 3 reactions ·
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
aspnet/LibraryManager#804 · 2 reactions ·
-
Difficulty 1/5 Under an hour Newbie friendliness 48/100
aspnet/LibraryManager#829 · 1 comment · 3 reactions ·
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
aspnet/LibraryManager#820 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
aspnet/LibraryManager#808 · 5 comments ·
All issues in aspnet/LibraryManager
Similar issues
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
-
Type: enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
apache/arrow-adbc#4809 ·
-
type/automation type/tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
microsoft/vscode-azurefunctions#5197 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
microsoft/microsoft-ui-reactor#1274 ·