aspiers/smooth-scrolling

C-p can scroll the window down

Open

#22 opened on Feb 19, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Emacs Lisp (14 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (108 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

If you position point near the end of the window (in the bottom margin) and press C-p then scrolling kicks in and moves your view in the opposite direction from where you're going.

I think it's never a good idea to scroll the window down when the user moves point up and the other way around.

I think this is a regression introduced in https://github.com/aspiers/smooth-scrolling/commit/d01c2950d5b35ce6dd31bb2b117cf33dd16b7cfe.

Contributor guide

Research direction
Examine the commit d01c2950d5b35ce6dd31bb2b117cf33dd16b7cfe to understand how scrolling behavior was changed. Then reproduce the issue by moving point near the bottom margin and pressing C p. Trace the code path to see why scrolling direction is inverted.
Tech stack
None
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
EmacsGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70