aspiers/github-notifications

make constants configurable

Open

#1 opened on Feb 27, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Ruby (1 fork)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (2 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

It would be better if these constants were all configurable via a YAML or .ini file:

SLEEP_INTERVAL = 5 * 60 # 5 minutes
ONLINE_CHECK_TARGET_HOST = "8.8.8.8"
PING_COUNT = 10
LOG_DIR = ENV['HOME'] + "/.log"
LOG_FILE = LOG_DIR + "/github-notifications.log"

Contributor guide

Research direction
Examine the existing constants in the source code, then implement a YAML or INI configuration file parser and replace the hardcoded values with configurable ones.
Tech stack
ruby
Domain
cli
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Ruby
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75