asmvik/yabai

Window Move and Resize broken in Screen Sharing sessions

Open

#2255 opened on Apr 30, 2024

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C (28,871 stars) (713 forks)batch import
help wanted

Description

Hello,

I believe I'm having a problem similar to #2211, which seems to be caused by a recent update, possibly commit 12400 (fixed bunch of weird macOS cursor quirks) ...

When using macOS's built-in Screen Sharing functionality, I cannot drag or resize any windows with the mouse - I can only do so with the keyboard. (See the video in #2211)

I believe this started around the time when drop zones were implemented, but it could be after that recent commit mentioned in the other issue. Disregard this. I found older commits where it works, and there are drop zones.

I can provide debug information in a moment, but to recreate it:

  • Enable screen sharing on a mac running the latest Yabai
  • Connect with macOS's Screen Sharing application or any VNC client and try to move windows around

Contributor guide

Tech stack
c
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic C programmingmacOS development environment
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Reproduce the issue by setting up a macOS screen sharing session and attempting to move/resize windows with yabai running. Investigate the regression by examining commit 1240042a1b5382d7fbfd74f140dce57880c68ed4 ('fixed bunch of weird macOS cursor quirks') and the related issue #2211. Focus on the cursor handling code in yabai, likely in files related to window management and macOS event handling. Determine if the cursor fix inadvertently broke mouse events during screen sharing.