arviz-devs/arviz

Check exceptions and exception messages

Open

#517 opened on Jan 10, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)TeX (1,818 stars) (495 forks)batch import
Help Wanted

Description

Check exceptions and exception messages reasonable and intuitive.

We have a few locations with (only) Exception-class raised and a lot of ValueErrors that might better be TypeErrors or something similar.

for example see plot_joint source.

Remember to update tests also.

Contributor guide

Tech stack
python
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
PythonException handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Look at the `plot joint` function in the ArviZ source code to identify exception types and messages. Check other locations where exceptions are raised without specific types. Update the corresponding tests to reflect changes. Review existing comments in the issue for further guidance.