arviz-devs/arviz

Check exceptions and exception messages

Open

#517 opened on Jan 10, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)TeX (495 forks)batch import
Help Wanted

Repository metrics

Stars
 (1,818 stars)
PR merge metrics
 (Avg merge 3d 8h) (5 merged PRs in 30d)

Description

Check exceptions and exception messages reasonable and intuitive.

We have a few locations with (only) Exception-class raised and a lot of ValueErrors that might better be TypeErrors or something similar.

for example see plot_joint source.

Remember to update tests also.

Contributor guide

Research direction
Examine the source code for exception raises, particularly in `plot joint`, and classify whether each `ValueError` should be a `TypeError` or another exception type. Then update corresponding tests.
Tech stack
python
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonPytest
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65