artem-zinnatullin/qualitymatters

DeveloperSettingsPresenter should not check if previous value of a setting was same

Open

#54 opened on Dec 6, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (204 forks)batch import
hacktoberfest

Repository metrics

Stars
 (1,759 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This logic should be moved to the model.

Contributor guide

Research direction
Look at DeveloperSettingsPresenter and the settings model to understand how the previous value check is currently done, then move that logic into the model.
Tech stack
javaandroid
Domain
mobile
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Java
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70