artem-zinnatullin/qualitymatters

Package structure: vertical over horizontal slicing

Open

#209 opened on Oct 18, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (204 forks)batch import
enhancementhacktoberfest

Repository metrics

Stars
 (1,759 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Code in qualitymatters at this moment is grouped into packages by layers (api, models, network, etc). Instead, it might be better to group bits of code by features / use cases. Such structure is easier to understand, extend and refactor. Please, see this article here: http://www.javapractices.com/topic/TopicAction.do?Id=205

It also might be not applicable to qualitymatters, since project itself is quite small, so horizontal slicing (by layers) can also work.

What do you think?

Contributor guide

Research direction
Read the referenced article about vertical vs horizontal slicing, then compare it with the current package structure in the repository to decide which is more suitable for the project's size and goals.
Tech stack
javaandroid
Domain
mobile
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65