Remove href="#" references to be compatible with frontend routers (i.e react-router)

Open Beginner friendly
#11 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
65/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
javascript, react
Domain
frontend

Research direction

Search the React components for href="#" references, then read the related pull request and commit for context on the intended change. Remove the references that interfere with react-router handling while preserving any needed link behavior, and verify that the components no longer contain these problematic href values.

Written by the indexing model from the issue text.

Description

Having href="#" in components breakes react-router route handling.
Also it has not real use but having proper cursor over links.

Related: https://github.com/alvarium/react-json/pull/1, https://github.com/alvarium/react-json/commit/382dd348836c68c451a0aa47462cc8c5c699f5bd

Maybe it can be removed in components. I can make a PR if needed.

Dominant language
JavaScript
Stars
97
Forks
38
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from arqex/react-json

All issues in arqex/react-json

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.