Lower values of `fixed_log2_rows` for the wrap machine

Open
#60 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
rust
Domain
cryptography

Research direction

Start in recursion/core/src/stark/mod.rs at the fixed_log2_rows values and run test_permutation_challenges with 19 and 20. Compare that failure with E2E Plonk proof generation and the warning about reducing fixed log2 rows. Done means explaining the test failure and lowering the value as far as the proof system safely allows.

Written by the indexing model from the issue text.

Description

The values for fixed_log2_rows here were decreased from 20 to 19 upstream v1.0.6-testnet (and again at v1.0.7-testnet), but this breaks the test test_permutation_challenges in Sphinx, so we kept it at 20

Setting it to 19 does not break E2E Plonk proof generation however, in fact with it at 20 it prints the warning "WARN fixed log2 rows can be potentially reduced: got 394238, expected 1048576". We should double-check why test_permutation_challenges is failing with a lower size

Running a quick test benchmark with 19 vs 20 showed no meaningful difference in total proving time, but this number changes how big the final gnark circuit is, so we'll want to decrease it as much as possible

Dominant language
Rust
Stars
80
Forks
8
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from argumentcomputer/sphinx

All issues in argumentcomputer/sphinx

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.