jetstreamExotic requiring secure connection (no opt-out)
#2,938 opened on Dec 13, 2023
Repository metrics
- Stars
- (2,679 stars)
- PR merge metrics
- (PR metrics pending)
Description
Describe the bug Argo Events requires secure connection to use jetstreamExotic, but it shouldn't - not because secure connections shouldn't be used, but because there are cases when they're not required, like on dev environments (which is my case) and when running inside a service mesh that provides mTLS.
To Reproduce Steps to reproduce the behavior:
- Run a NATS server with JetStream enabled, but without any secure connections enabled
- Spin up Argo Events
- Create an EventBus pointing to the NATS server, using jetstreamExotic
- Check the logs
Expected behavior I should be able to connect the EventBus with the external NATS server without problems.
Screenshots (None)
Environment (please complete the following information):
- Kubernetes: v1.27.3
- Argo: v3.5.1
- Argo Events: latest+ec96ecd
Additional context Here's where the secure connection is forced: https://github.com/argoproj/argo-events/blob/master/eventbus/jetstream/base/jetstream.go#L70
Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.