Always true condition in IPAddress string-to-ipv6 conversion

Open
#249 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
cpp
Domain
api, embedded-iot

Research direction

Read api/IPAddress.cpp around line 204 and inspect the surrounding string-to-IPv6 conversion logic. Determine the intended behavior when the checked character cannot be '\0', then validate the resulting correction against the conversion behavior; the issue is resolved when the condition and its expected behavior are consistent.

Written by the indexing model from the issue text.

Description

bug

Always true condition in IPAddress string-to-ipv6 conversion

https://github.com/arduino/ArduinoCore-API/blob/master/api/IPAddress.cpp#L204

*address is checked to be ':' so it cannot be '\0'. I'm not really sure what the intended behaviour is here.

Dominant language
C++
Stars
306
Forks
150
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from arduino/ArduinoCore-API

All issues in arduino/ArduinoCore-API

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.