ardalis/modulith

Prefer csproj method for InternalsVisibleTo

Open

#55 opened on Sep 30, 2024

View on GitHub
 (0 comments) (1 reaction) (0 assignees)C# (20 forks)github user discovery
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (184 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#internalsvisibleto

This way, you can skip the AssemblyInfo.cs creation.

Also, this might work:

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>net6.0</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <InternalsVisibleTo Include="$(AssemblyName).Tests" />
  </ItemGroup>
</Project>

Contributor guide

Research direction
Update the project file to use the InternalsVisibleTo MSBuild property instead of creating an AssemblyInfo.cs file with InternalsVisibleTo attribute.
Tech stack
csharp
Domain
build system
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
.NETMSBuild
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80