ardalis/SmartEnum

Add null-safety identifier in SmartEnum.TryFromValue(TValue value, out ...)

Open

#559 opened on Nov 24, 2024

View on GitHub
 (4 comments) (0 reactions) (1 assignee)C# (185 forks)github user discovery
enhancementgood first issue

Repository metrics

Stars
 (2,420 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi, is it possible to add nullable identifier to parameters of TryFromValue method, so IDE will not trigger CS8604 warning?

image

Love the work. Thanks. Regards, rhdwr

Contributor guide

Research direction
Find the TryFromValue method definition in the SmartEnum source code and add the nullable ? annotation to the TValue value parameter. Also check for any overloads and update nullable annotations in the out parameter if needed. Ensure the change is compatible with nullable enabled and disabled contexts.
Tech stack
csharp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Nullable reference types
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80