appsmithorg/appsmith

(JS-0458) Definitions for unused states detected

Open

#7943 opened on Sep 29, 2021

View on GitHub
 (20 comments) (0 reactions) (1 assignee)TypeScript (39,454 stars) (4,508 forks)batch import
Good First IssueLow effortTask

Description

Description

You should avoid defining states that are not being used because unused states might affect while refactoring the codebase and introduces unnecessary operations by ReactJS. It is recommended to plan the behavior and operation of the component.

Occurrences

There are 9 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/appsmithorg/appsmith/issue/JS-0458/occurrences/

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic React knowledgeUnderstanding of component stateFamiliarity with code editing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Review the 9 occurrences listed in the DeepSource link (deepsource.io/gh/appsmithorg/appsmith/issue/JS 0458/occurrences/). Each occurrence points to a file and line number where an unused state definition is detected. For each case, verify that the state variable is indeed not used anywhere in the component or its children. If unused, remove the state definition and any associated setter calls. Ensure that the component still functions correctly by checking for any indirect usage. The repository is TypeScript based React, so look for useState calls in function components. The issue has an assignee, so coordinate if necessary.