appsmithorg/appsmith

[Improvement]: Migrate JS Library Icons to Use Internal CDN Instead of Third-Party URLs

Open

#35560 opened on Aug 9, 2024

View on GitHub
 (11 comments) (0 reactions) (1 assignee)TypeScript (39,454 stars) (4,508 forks)batch import
Custom JS LibrariesEnhancementGood First IssueJavascript ProductQuery & JS PodQuery Widgets & IDE Pod

Description

Is there an existing issue for this?

  • I have searched the existing issues

Summary

Within the JS Library feature of our application, we currently rely on third-party URLs to source icons for various JavaScript libraries. This dependency on external resources can lead to issues such as broken icons and inconsistent user experiences if those URLs become unavailable.

Proposed Solution:

Migrate all JS Library icons to be hosted on our internal CDN to ensure their consistent availability and performance. Update the icon fields in the JS Library configurations to point to the new CDN-hosted versions.

Benefits:

Ensures that icons for JS libraries are always available and not dependent on external services. Potentially faster icon loading times by reducing reliance on third-party hosts. Enhanced security and greater control over the assets used in our application.

Why should this be worked on?

This should be worked on to ensure reliability, performance, and security. By moving JS Library icons to our internal CDN, we eliminate the risk of broken icons from third-party outages, reduce load times, and maintain better control over our resources. This leads to a more consistent and dependable user experience.

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Appsmith codebaseBasic knowledge of ReactBasic knowledge of TypeScriptUnderstanding of internal CDN assets
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Identify all JS Library configuration files that contain icon URLs. These are likely in frontend code under src/ or similar. Look for patterns like 'https://cdn.jsdelivr.net' or other third party CDNs in icon fields. Check if there are any existing discussions or linked PRs that indicate a preferred internal CDN path. Update each icon field to point to the internal CDN URL. Verify the icons render correctly after the change.