appsmithorg/appsmith

[Bug]: Changing the selection of Border Radius/Box Shadow of Buttons in JSONForm is not visible in property pane

Open

#24376 opened on Jun 12, 2023

View on GitHub
 (24 comments) (0 reactions) (1 assignee)TypeScript (39,454 stars) (4,508 forks)batch import
BugCommunity ContributorContributor Expressed InterestGood First IssueJSON FormLowNeeds TriagingProductionQuery Widgets & IDE PodWidgets Product

Description

Is there an existing issue for this?

  • I have searched the existing issues

Description

On changing the box radius and box shadow of "Submit" & "Reset" button are not visible, although the changes are happening in widget according to selection in the property pane.

Steps To Reproduce

  1. Drag & Drop a JSONForm
  2. Go to Style tab
  3. Under the Submit button styles, change the Border Radius
  4. Observe that the change affects the widget but the selection in property pane is still same
  5. Try same with Reset Button styles
  6. Observe that there is no change in property pane on selecting different Border radius/Box shadow

Public Sample App

No response

Environment

Production

Issue video log

https://www.loom.com/share/9212808497cf42d08ccd502bb22b6047

Version

Cloud/Production

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the bug where the property pane does not reflect selected Border Radius/Box Shadow for JSONForm buttons, though the widget updates. Look at the JSONForm widget property pane implementation, likely in `app/client/src/widgets/JSONFormWidget/`. Check how the property pane state is synced with widget properties and identify where the selection state is not updating. Review the 24 comments for additional context, especially any hints from assignee or maintainers on the root cause.