apple/turicreate

Image Similarity exported coreml spec includes two useless layer

Open

#2,697 opened on Nov 20, 2019

View on GitHub
 (8 comments) (0 reactions) (1 assignee)C++ (11,135 stars) (1,161 forks)batch import
buggood first issueimage similarity

Description

Coreml model spec for image similarity has two useless layer: softmax and fc1, which doesn't effect the result but should be removed.

Contributor guide

Tech stack
cpppython
Domain
machine learningperformance
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue is in the CoreML model export code for image similarity. Look for files related to CoreML conversion, likely in the Python toolkit or C++ core. The two layers (softmax and fc1) need to be removed from the exported spec. Review the issue comments for potential discussion on which files to modify.