apple/swift-nio

We should offer the same `[get/set]MultipleIntegers` as we offer for `[read/write]MultipleIntegers` methods on ByteBuffer

Open

#2,736 opened on Jun 7, 2024

View on GitHub
 (14 comments) (1 reaction) (0 assignees)Swift (8,453 stars) (749 forks)batch import
good first issue

Description

Normally we provide all four variants of methods like get/set/read/write on the various ByteBuffer operations but we seem to missing the get/set variants for the multipleInterger based methods.

Contributor guide

Tech stack
swift
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
SwiftSwiftNIOByteBuffer API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
This issue requests adding `getMultipleIntegers` and `setMultipleIntegers` methods to `ByteBuffer`, mirroring existing `readMultipleIntegers` and `writeMultipleIntegers`. Look at the source file `Sources/NIO/ByteBuffer Views.swift` or similar to understand the pattern. The existing `read/write` methods are in `ByteBuffer core.swift` or `ByteBuffer views.swift`. Implement by following the same signature and logic, just using the `get/set` API instead of the `read/write` API. Ensure proper bounds checking and type safety.