apple/swift-nio-extras

NIOWritePCAPHandler crashes if used with UNIX Domain Sockets

Open

#92 opened on Jun 12, 2020

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Swift (95 forks)auto 404
good first issuekind/bug

Repository metrics

Stars
 (250 stars)
PR merge metrics
 (PR metrics pending)

Description

When using NIOWritePCAPHandler with UNIX Domain Sockets, it crashes.

That's because UNIX Domain Sockets don't have IP addresses and ports.

If the user passes a fakeLocal/RemoteAddress, everything's good but we should just have a default one in case the user doesn't.

Contributor guide

Research direction
Implement a default address for UNIX Domain Sockets in NIOWritePCAPHandler to prevent crashes.
Tech stack
swift
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftNIO
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80