var listID: String
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 42/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- swift
- Domain
- mobile-dev
Research direction
Open ContactsList.swift and inspect the Contact extension and current listID implementation. Update the list identifier as proposed, then verify that cloud-fetched changes update list items when fields beyond the contact name change.
Written by the indexing model from the issue text.
Description
In ContactsList.swift extension Contact
// In order for the list to update properly when fetch changes from the cloud, we need to use something other than the contact ID for the list item ID.
var listID: String { "\(self.id)\(Self.listIDSeparator)\(self.name)" }
The problem with this approach is when you start adding more fields to Contact. Your approach doesn't guarantee updates when changes are fetched.
I propose changing to the following:
var listID: String { "\(self.id)\(Self.listIDSeparator)\(self.userModificationDate)" }
In my testing, this solves all update issues regardless of adding fields to Contact.
Thoughts?
- Dominant language
- Swift
- Stars
- 270
- Forks
- 15
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apple/sample-cloudkit-sync-engine
-
Difficulty 4/5 3-5 days Newbie friendliness 28/100
apple/sample-cloudkit-sync-engine#17 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
apple/sample-cloudkit-sync-engine#15 · 6 comments · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
apple/sample-cloudkit-sync-engine#13 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
apple/sample-cloudkit-sync-engine#6 · 3 reactions ·
-
Implementation flaw Open
Difficulty 5/5 Over a week Newbie friendliness 25/100
apple/sample-cloudkit-sync-engine#5 · 14 comments · 1 reaction ·
All issues in apple/sample-cloudkit-sync-engine
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
area:general bug P1 security
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
uttrflow/uttrflow-swift#1333 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
maxgoedjen/secretive#840 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
manaflow-ai/cmux#13763 ·