plot_heatmaps / plot_heatmaps_logarithmic crash on their own default dimensions=None
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- jupyter, python
- Domain
- data-visualization
Research direction
Start with plot_heatmaps and plot_heatmaps_logarithmic in src/graphing/plotting.py at lines 633 and 759, then trace their dimensions handling into get_heatmap_data in src/graphing/heatmap.py:207. Check both calls with dimensions=None and compare them with the existing wrong-length error path. Done means the default behavior no longer raises the reported TypeError and dimensions handling is consistent with the chosen API behavior.
Written by the indexing model from the issue text.
Description
Both functions declare dimensions=None as the default (src/graphing/plotting.py:633
and :759), but get_heatmap_data immediately does len(dimensions)
(src/graphing/heatmap.py:207):
TypeError: object of type 'NoneType' has no len()
plot_heatmaps_logarithmic fails slightly differently: TypeError: '>' not supported
between instances of 'float' and 'NoneType'.
get_heatmap_data already has a friendly error path printing the expected dimensions
format when the list is the wrong length — None just never reaches it. Either guard
for None there, or make dimensions a required positional argument since there's no
usable default.
- Dominant language
- Jupyter Notebook
- Stars
- 455
- Forks
- 48
- Avg merge
- 4m
- Merged PRs (30d)
- 2
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apple/GCGC
-
Stale empty checkpoint file src/.ipynb_checkpoints/__init__-checkpoint.py committed to the repo Open
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
bancolombia/sentinel#23 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
AOSSIE-Org/OrgExplorer#245 · 1 assignee ·
-
tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
gordonwatts/test-wsl2-llm#151 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100