appc/spec

discovery: be more discerning about HTTP errors

Open

#114 opened on Jan 13, 2015

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Go (143 forks)github user discovery
component/toolinghelp wanted

Repository metrics

Stars
 (1,253 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Right now discovery just recursively walks up the tree on any error, alternately trying https and http. For example, when discovering the name example.com/foo/bar/baz, it will make requests like so: https://example.com/foo/bar/baz http://example.com/foo/bar/baz https://example.com/foo/bar/ http://example.com/foo/bar/ ...

However for a certain class of errors, it doesn't make much sense to do this; for example if dialing example.com:443 times out the first time it's probably not worth retrying it for every branch. Some errors should just propagate directly (fail early)

Contributor guide

Research direction
Identify the specific HTTP errors that should cause early failure (e.g., timeouts, connection refused) and modify the discovery logic to skip retries for those errors.
Tech stack
go
Domain
backendnetworking
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60