Error when fetching past end of Launches
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 52/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- graphql, typescript
Research direction
Start with the LaunchConnection schema below the Query type and the resolver return object shown in the issue. Reproduce a request using a cursor past the end of the launches, then make the schema and returned cursor behavior consistent. Done means the request returns a valid GraphQL response instead of INTERNAL_SERVER_ERROR.
Written by the indexing model from the issue text.
Description
Cursor is defined as non-nullable:
type LaunchConnection { # add this below the Query type as an additional type.
cursor: String!
hasMore: Boolean!
launches: [Launch]!
}
But if no launches are retrieved (for example if you pass in a cursor for which hasMore was false), then the code will carefully return null for the cursor:
return {
launches,
cursor: launches.length ? launches[launches.length - 1].cursor : null,
Resulting in INTERNAL_SERVER_ERROR:
- Dominant language
- TypeScript
- Stars
- 1.2k
- Forks
- 808
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apollographql/fullstack-tutorial
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
investigate
Difficulty 4/5 3-5 days Newbie friendliness 30/100
-
documentation
apollographql/fullstack-tutorial#285 · 3 comments · 1 assignee ·
-
investigate
Difficulty 3/5 1-2 days Newbie friendliness 35/100
apollographql/fullstack-tutorial#255 · 2 reactions ·
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 25/100
apollographql/fullstack-tutorial#254 · 2 comments ·
All issues in apollographql/fullstack-tutorial
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
bug v2
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
modelcontextprotocol/inspector#2458 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
railmapgen/rmp-gallery#4068 ·
-
Mend: dependency security vulnerability status: needs triage 🕵️♀️
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
carbon-design-system/ibm-products#9907 ·