Integration Tests Not Properly Mocked

Open

#90 opened on Jun 21, 2019 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 3/5
Estimated time: 1-2 days
Newbie friendliness: 35/100

Issue type: Bug
Clarity: Needs clarification
Activity status: Stale
Tech stack: graphql, node.js, typescript
Domain: api, backend, testing

Research direction

Start by running the integration tests with networking disabled and inspect the example that assigns launchAPI.get, then trace which RESTDataSource method handles the launch lookup. The issue names no files or test command; done should mean the integration tests pass offline without requesting api.spacexdata.com and still return the expected rocket data.

Written by the indexing model from the issue text.

Description

I followed the integration tests example pattern in my own app.

   // mock the datasources' underlying fetch methods, whether that's a REST
    // lookup in the RESTDataSource or the store query in the Sequelize datasource
    launchAPI.get = jest.fn(() => [mockLaunchResponse]);

However I noticed it was still making api calls to the rest endpoint. I then cloned this repo turned off my wifi and ran the integration tests and sure enough I got an error.

errors": Array [
    +     Object {
    +       "extensions": Object {
    +         "code": "INTERNAL_SERVER_ERROR",
    +         "exception": Object {
    +           "code": "ENOTFOUND",
    +           "errno": "ENOTFOUND",
    +           "message": "request to https://api.spacexdata.com/v2/launches?flight_number=30 failed, reason: getaddrinfo ENOTFOUND api.spacexdata.com api.spacexdata.com:443",
    +           "type": "system",
    +         },
            },
    -       "rocket": Object {
    -         "type": "FT",
    -       },
    +       "locations": Array [
    +         Object {
    +           "column": 3,
    +           "line": 2,
    +         },
    +       ],
    +       "message": "request to https://api.spacexdata.com/v2/launches?flight_number=30 failed, reason: getaddrinfo ENOTFOUND api.spacexdata.com api.spacexdata.com:443",
    +       "path": Array [
    +         "launch",
    +       ],

This tells me that launchAPI.get is not being properly mocked. Which I think would make sense as there is no launchAPI.get however there is a launchAPI.prototype.get however that doesn't seem to work when I change the tests to that.

Any ideas?

Dominant language: TypeScript
Stars: 1.2k
Forks: 808
PR merge metrics: No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

[MagmaFusion] rapports qualité - contenus des rubriques en anglais manquants Open

Difficulty 2/5 1-3 hours Newbie friendliness 65/100

InseeFr/Bauhaus#1634 · Opened Sep 23, 2026
[Bug]: SSH host picker duplicates configured aliases and known_hosts targets Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

pingdotgg/t3code#13270 · Opened Sep 23, 2026
resetSseResponseWait and noteRequestProgress silently fail to re-arm the 60s relay timeout if progress tokens arrive as strings Open

bug v2

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

modelcontextprotocol/inspector#2458 · 1 comment · Opened Sep 23, 2026
Resources: Update work of changsha Open

Difficulty 1/5 Under an hour Newbie friendliness 75/100

railmapgen/rmp-gallery#4068 · Opened Sep 23, 2026
sass-1.105.0.tgz: 1 vulnerabilities (highest severity is: 7.5) Open

Mend: dependency security vulnerability status: needs triage 🕵️‍♀️

Difficulty 2/5 1-3 hours Newbie friendliness 70/100

carbon-design-system/ibm-products#9907 · Opened Sep 23, 2026

More TypeScript issues