apache/superset

supersetCanCSV property naming could be better

Open

#24290 opened on Jun 5, 2023

View on GitHub
 (12 comments) (1 reaction) (0 assignees)TypeScript (72,837 stars) (17,291 forks)batch import
good first issuerisk:breaking-change

Description

Description

Javascript code uses supersetCanCSV property to check wether user is allowed to download chart as csv, excel or image.

This is bit outdated, supersetCanDownload would be more informative?

Contributor guide

Tech stack
typescriptreact
Domain
frontenddeveloper experience
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with JavaScript/TypeScriptBasic knowledge of Apache Superset codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Search the codebase for all occurrences of 'supersetCanCSV' and replace them with 'supersetCanDownload'. Ensure that all references in JavaScript/TypeScript files, tests, and documentation are updated. Confirm that the new naming is consistent with existing patterns.