[BUG] SofaMetaDataHandler uses raw .equals on possibly-null fields → NPE

Open Beginner friendly
#6,740 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
84/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
java
Domain
backend

Research direction

Inspect shenyu-plugin/shenyu-plugin-proxy/shenyu-plugin-rpc/shenyu-plugin-sofa/src/main/java/org/apache/shenyu/plugin/sofa/handler/SofaMetaDataHandler.java at lines 39 and 43, then compare the null-safe handling in AbstractDubboMetaDataHandler. Verify that a metadata re-handle event with null rpcExt or serviceName no longer throws an NPE.

Written by the indexing model from the issue text.

Description

plugin: sofa priority: medium type: bug
  • severity: Medium
  • files: shenyu-plugin/shenyu-plugin-proxy/shenyu-plugin-rpc/shenyu-plugin-sofa/src/main/java/org/apache/shenyu/plugin/sofa/handler/SofaMetaDataHandler.java:39,43
  • description: exist.getServiceName().equals(metaData.getServiceName()) and exist.getRpcExt().equals(metaData.getRpcExt()) without null-safety. MetaData.rpcExt defaults to null. Unlike AbstractDubboMetaDataHandler which uses Objects.equals(...), the sofa handler NPEs if a registered metadata has null rpcExt/serviceName.
  • impact: A metadata re-handle event for a sofa path whose rpcExt/serviceName is null throws NPE.
  • suggested_fix: Use Objects.equals(...) (as the dubbo handler does).
  • confidence: Medium
  • related_existing: none

Identified during the 2026-08-02 deep re-scan; full list in docs/scan2-2026-08-02/06-medium-tiers.md.

Dominant language
Java
Stars
8.8k
Forks
3.1k
Avg merge
4d 11h
Merged PRs (30d)
85

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/shenyu

All issues in apache/shenyu

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.