apache/sedona

Optimize shellcheck ignores for actionlint pre-commit

Open

#2738 opened on Mar 12, 2026

View on GitHub
 (9 comments) (0 reactions) (0 assignees)Scala (1,953 stars) (693 forks)batch import
github_actionsgood first issuepre-commitshell

Description

Original failed run seen here:

https://github.com/apache/sedona/actions/runs/22992869182/job/66757741342

This hook is here:

https://github.com/apache/sedona/blob/3ac639748416b8e6975a409e53bb571bc36a6343/.pre-commit-config.yaml#L510

So maybe we can remove some ignores and clean up the code ??

Contributor guide

Tech stack
shellgithub actions
Domain
devopstooling
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of shell scriptsFamiliarity with pre commit hooks
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine the linked failed run and the specific shellcheck ignore lines in .pre commit config.yaml. Identify which shellcheck rules can be enabled without causing failures, and consider refactoring the shell scripts to comply with those rules. Review comments for any suggestions.