apache/royale-asjs

inject_html does not work in modules

Open

#427 opened on Jun 16, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)ActionScript (381 stars) (120 forks)batch import
help wanted

Description

Hi,

putting the pieces together for the next blog example about modules I found "inject_html" does not work for modules. If you think about it is normal, since inject adds to the html template, so if the class with the inject is in a module, the app does not know about it.

Only if we improve modules with the capability to write the inject lines in the html template this could be fixed.

Don't know how hard this could be.

In the BE0013 example I want to use Material Icons that use inject_htnk to add the Material Icons line to the html and make the icons available to the app. To work around the problem I put a import in the App:

import MaterialIconType; MaterialIconType;

This means as well add the library dependency in the Application instead of the module, defeating a bit the module purpose.

In this way the inject line is in the final html and when I use a font icon in a module I get the proper icon.

Can we solve this in some way?

Contributor guide

Tech stack
None
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of Apache Royale module systemKnowledge of HTML injection in Royale
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Review the source code to understand how `inject html` works and why it fails in modules. Look at the comments for any suggested approaches. The files involved likely include the module loader and HTML template generation. Consider adding a mechanism for modules to register injectable HTML content.