Cold data control may skip the group with the highest threshold

Open Beginner friendly
#10,851 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
java
Domain
backend

Research direction

Start at ColdDataCgCtrService and locate the comparator that orders configured thresholds. Confirm the ordering with a large threshold difference, then verify that the three largest eligible groups are selected for deceleration without comparator overflow.

Written by the indexing model from the issue text.

Description

Description

ColdDataCgCtrService sorts configured thresholds by subtracting two long values and narrowing the result to int. A large threshold delta can overflow the comparator and place the largest threshold after smaller entries. Because only three groups are decelerated per cycle, the group with the highest threshold can be skipped.

Expected behavior

Sort thresholds with Long.compare so the three largest eligible groups are always processed.

Dominant language
Java
Stars
22.6k
Forks
12k
Avg merge
3d 12h
Merged PRs (30d)
25

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/rocketmq

All issues in apache/rocketmq

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.