TopicConfig.decode mutates state or throws for malformed config

Open Beginner friendly
#10,835 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
java
Domain
distributed-systems

Research direction

Start at TopicConfig.decode and trace how topicName, numeric fields, and enum fields are parsed and assigned. Verify malformed mandatory fields return false without changing the existing object, and confirm valid configurations still decode successfully.

Written by the indexing model from the issue text.

Description

TopicConfig.decode assigns topicName before parsing numeric and enum fields. A malformed serialized config can throw IllegalArgumentException after partially mutating the target object. Expected behavior: return false and leave the existing object unchanged when mandatory fields cannot be parsed.

Dominant language
Java
Stars
22.6k
Forks
12k
Avg merge
3d 12h
Merged PRs (30d)
25

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/rocketmq

All issues in apache/rocketmq

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.