[Bug] pulsar-perf outputs values in nanos with values saying "ms"

Open Beginner friendly
#23,879 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
java
Domain
cli

Research direction

Start in pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java at lines 464-472, then run pulsar-perf consume to compare the reported latency values with their labels. Trace how the histogram values are read and confirm that the output values are expressed in milliseconds when labeled ms.

Written by the indexing model from the issue text.

Description

type/bug
Search before asking
  • I searched in the issues and found nothing similar.
Read release policy
  • I understand that unsupported versions don't get bug fixes. I will attempt to reproduce the issue on a supported version of Pulsar client and Pulsar broker.
Version

2.10+, 3.x

Minimal reproduce step

run pulsar-perf consume

What did you expect to see?

latency values in milliseconds, as labels suggest

What did you see instead?
org.apache.pulsar.testclient.PerformanceConsumer - Throughput received:  332571 msg --- 3002.897  msg/s --- 165.144 Mbit/s  --- Latency: mean: 18740630.690 ms - med: 18640383 - 95pct: 20181503 - 99pct: 20482175 - 99.9pct: 20512767 - 99.99pct: 20512895 - Max: 20512895

value sin nanos with labels "ms"

Anything else?

I think here https://github.com/apache/pulsar/blob/e5bd77419e91d1602731cd0c1d02a738e1b7ebc7/pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java#L464-L472 (and possibly in other places) histogram returns latency as it tracked, in nanoseconds. The perf tool should translate these into millis, as labeled.

This is not a blocker/not a priority, logging this as "gotcha" if anyone else wonders about the mismatch between values and labels.

Are you willing to submit a PR?
  • I'm willing to submit a PR!
Dominant language
Java
Stars
15.3k
Forks
3.8k
Avg merge
1d 45m
Merged PRs (30d)
169

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/pulsar

All issues in apache/pulsar

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.