apache/pulsar

Make Java Client Authentication Asynchronous

Open

#19,429 opened on Feb 5, 2023

View on GitHub
 (13 comments) (0 reactions) (0 assignees)Java (3,485 forks)batch import
Stalearea/clientgood first issuehelp wantedtype/enhancement

Repository metrics

Stars
 (13,697 stars)
PR merge metrics
 (Avg merge 3d 10h) (146 merged PRs in 30d)

Description

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

The OAuth2 client's authenticate call is blocking, which is not great for the client, and is bad for the proxy because the proxy authenticates from a netty event loop.

Solution

In the same way that PIP 97 #12105 make the AuthenticationProvider async, we should update the Authentication interface.

Alternatives

No response

Anything else?

This change will likely require a PIP. I am unable to write such a PIP at this time, so I am creating this issue to keep track of this missing feature.

Are you willing to submit a PR?

  • I'm willing to submit a PR!

Contributor guide

Research direction
Study the existing Authentication interface and its blocking authenticate method. Review PIP 97 as an example of how the AuthenticationProvider was made async. Then propose a similar async API for Authentication, focusing on making OAuth2 client authentication non blocking.
Tech stack
java
Domain
authenticationapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaOAuth2
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40