apache/pulsar

Make Java Client Authentication Asynchronous

Open

#19,429 opened on Feb 5, 2023

View on GitHub
 (13 comments) (0 reactions) (0 assignees)Java (13,697 stars) (3,485 forks)batch import
Stalearea/clientgood first issuehelp wantedtype/enhancement

Description

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

The OAuth2 client's authenticate call is blocking, which is not great for the client, and is bad for the proxy because the proxy authenticates from a netty event loop.

Solution

In the same way that PIP 97 #12105 make the AuthenticationProvider async, we should update the Authentication interface.

Alternatives

No response

Anything else?

This change will likely require a PIP. I am unable to write such a PIP at this time, so I am creating this issue to keep track of this missing feature.

Are you willing to submit a PR?

  • I'm willing to submit a PR!

Contributor guide

Tech stack
java
Domain
backendauthentication
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaAsynchronous programmingPulsar authentication model
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Examine the existing `Authentication` interface in the Pulsar repository (e.g., pulsar client/src/main/java/org/apache/pulsar/client/api/Authentication.java) and the async `AuthenticationProvider` introduced in PIP 97 (#12105). Understand the current blocking authenticate call and identify how to convert it to a completable future. Review the linked PIPs and comments in issue #19429 for design discussions. Consider that this change may require a new PIP; study the process for proposing PIPs in Apache Pulsar.