apache/pulsar

Hbase connector does not have working tests

Open

#14,434 opened on Feb 23, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (3,485 forks)batch import
help wantedtype/enhancement

Repository metrics

Stars
 (13,697 stars)
PR merge metrics
 (Avg merge 3d 10h) (146 merged PRs in 30d)

Description

Describe the bug

Hbase connector does not have working tests, thus its state and compatibility with various library changes is unclear.

To Reproduce

The only useful test (let's ignore HbaseSinkConfigTest test) is HbaseGenericRecordSinkTest with one test method which is disabled since the day it was committed in Jan 2019 https://github.com/apache/pulsar/pull/3368 : https://github.com/apache/pulsar/blob/9fe2f418200f4231326fc273e5671c5536b9bf65/pulsar-io/hbase/src/test/java/org/apache/pulsar/io/hbase/sink/HbaseGenericRecordSinkTest.java#L84-L85

I tried enabling the test and running it on my mac, the test resulted in panic and MacOS crash.

Integration tests were never finished and committed: https://github.com/apache/pulsar/pull/3695

Expected behavior

Working set of tests covering functionality, running on CI

Contributor guide

Research direction
Investigate the disabled HbaseGenericRecordSinkTest to understand why it causes a crash, then fix the test and enable it. Additionally, develop integration tests for the HBase connector using Testcontainers or a local HBase instance.
Tech stack
java
Domain
backenddatabasetesting
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaMavenHBase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40