No Error handling for Deserialize method which ends up crashing Node JS

Open
#422 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp, javascript, node.js
Domain
api

Research direction

Start at MessageId.deserialize and compare its error handling with the client handling introduced in PR #307. Reproduce the invalid-buffer case and trace the deserialize binding; done means invalid input no longer terminates Node.js with an uncaught C++ exception.

Written by the indexing model from the issue text.

Description

Hello Team

Here I am trying to serialize and deserialize messageId for my business use case

but issue is for proper error handling if in case we pass invalid buffer data to MessageId.deserialize method then it throws C++ exception
libc++abi: terminating due to uncaught exception of type std::invalid_argument: Failed to parse serialized message id
which is not handled by pulsar-client and node JS crashes

I see similar issue was there while creating a client too but that got fixed with this issue and PR https://github.com/apache/pulsar-client-node/pull/307/files
where it was wrapped with try catch block
but deserialize method is still not fixed

Dominant language
C++
Stars
164
Forks
99
Avg merge
5d 18h
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/pulsar-client-node

All issues in apache/pulsar-client-node

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.