Now that acknowledge returns a Promise, should negativeAcknowledge return a Promise too?
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- javascript, nodejs
Research direction
Start with the Consumer type's acknowledge and negativeAcknowledge methods, then read pull request #200 to understand the earlier Promise change. Determine whether negativeAcknowledge should match that API and identify the relevant implementation and tests; done means the decision is settled and any agreed API change is covered.
Written by the indexing model from the issue text.
Description
The acknowledge method of the Consumer type was recently updated to return a Promise. Should the negativeAcknowledge method also return a Promise?
- Dominant language
- C++
- Stars
- 164
- Forks
- 99
- Avg merge
- 5d 18h
- Merged PRs (30d)
- 2
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/pulsar-client-node
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
apache/pulsar-client-node#477 ·
-
公司网络无法访问海外站点，如何解决？ Open
Difficulty 4/5 3-5 days Newbie friendliness 35/100
apache/pulsar-client-node#455 · 3 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
apache/pulsar-client-node#432 · 2 reactions ·
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
apache/pulsar-client-node#431 · 3 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
apache/pulsar-client-node#429 · 1 comment ·
All issues in apache/pulsar-client-node
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
flutter-webrtc/flutter-webrtc#2206 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
google-ai-edge/LiteRT-LM#3739 ·
-
Component: GLib
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
brave/brave-browser#59300 ·
-
Mute ydb/tests/functional/dstool/test_canonical_requests.py.Test.test_group_take_snapshot in main Openai_reviewed
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
ydb-platform/ydb#53974 · 3 comments ·