Missing error-path test coverage for invalid feature JSON in DefaultConfigurationStoreTest

Open Beginner friendly
#4,639 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
java
Domain
testing

Research direction

Start with DefaultConfigurationStoreTest and trace how BehaviorChangesConfiguration and FeatureConfiguration handle configuration parsing. Add coverage for malformed JSON, unexpected JSON structure, and parsing failures, then run the focused test to confirm invalid feature JSON is rejected through a clear error or exception path.

Written by the indexing model from the issue text.

Description

bug
Describe the bug

DefaultConfigurationStoreTest currently covers feature configuration defaults and valid configuration behavior.

However, it does not test invalid feature JSON scenarios in BehaviorChangesConfiguration / FeatureConfiguration handling.

Missing cases:

  • malformed feature JSON
  • invalid or unexpected JSON structure
  • error path when configuration parsing fails

Impact:
Without this test coverage, invalid configuration input may not be properly validated or may fail silently.

Expected behavior:
Invalid feature JSON should be rejected with a clear error/exception path.

Suggested fix:
Add a unit/integration test in DefaultConfigurationStoreTest to validate invalid feature JSON handling and ensure proper error response.

To Reproduce

Not applicable — this is a missing test coverage issue in existing codebase.

Actual Behavior

Invalid feature JSON in BehaviorChangesConfiguration is not explicitly tested in DefaultConfigurationStoreTest.

Expected Behavior

Invalid feature JSON should be validated and rejected with a proper error/exception path.

Additional context

This issue is based on observed missing test coverage in DefaultConfigurationStoreTest for BehaviorChangesConfiguration handling of invalid feature JSON.

System information

OS: Linux
Polaris Catalog Version: latest (main branch)
Object storage & setup: local/test environment

Dominant language
Java
Stars
2.1k
Forks
528
Avg merge
2d 6h
Merged PRs (30d)
135

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/polaris

All issues in apache/polaris

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.