apache/pinot

Add read APIs for `BOOLEAN` and `TIMESTAMP`

Open

#9,418 opened on Sep 16, 2022

View on GitHub
 (5 comments) (0 reactions) (2 assignees)Java (1,234 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (4,937 stars)
PR merge metrics
 (Avg merge 6d 7h) (186 merged PRs in 30d)

Description

Currently BOOLEAN is supported using the INT data type, and TIMESTAMP is supported using the LONG data type. Even though the storage format are the same, the behavior should be different. E.g. reading BOOLEAN as STRING should give "true" or "false" instead of 1 or 0; reading DOUBLE as BOOLEAN should give doubleVal != 0 instead of (int) doubleVal. In order to achieve the expected behavior, we need to add read APIs for these 2 data types. It should be similar to how the BIG_DECIMAL is handled (storage format is BYTES). We want to add type support in:

  • Dictionary
  • ForwardIndexReader
  • BlockValSet
  • TransformFunction

Contributor guide

Research direction
Follow the implementation of BIG DECIMAL read APIs. Identify the relevant files for Dictionary, ForwardIndexReader, BlockValSet, and TransformFunction for INT and LONG types, then adapt them for BOOLEAN and TIMESTAMP, ensuring correct behavior in type conversions (e.g., BOOLEAN as STRING, DOUBLE as BOOLEAN).
Tech stack
java
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75