apache/pinot

Support cleaning up segments when a batch build fails

Open

#8,864 opened on Jun 8, 2022

View on GitHub
 (8 comments) (0 reactions) (1 assignee)Java (1,234 forks)batch import
good first issuehelp wanted

Repository metrics

Stars
 (4,937 stars)
PR merge metrics
 (Avg merge 6d 7h) (186 merged PRs in 30d)

Description

Currently if segment generation fails for one of the input files, segments created from previous input files will be left in the output directory. A new cleanupOnFailure flag (default is false) would trigger the deletion of these segments. Note that clearing the output directory isn't acceptable, as there might be existing files.

This change would have to be applied to all batch segment generation plugins (stand-alone, Hadoop, Spark).

Contributor guide

Research direction
Implement a boolean flag 'cleanupOnFailure' (default false) in batch segment generation plugins (stand alone, Hadoop, Spark). On build failure, delete segments created for that batch without deleting the output directory. Ensure thread safety and handle partial failures.
Tech stack
java
Domain
database
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Java
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65