apache/pinot

Validating duplicate config properties

Open

#7,882 opened on Dec 8, 2021

View on GitHub
 (2 comments) (2 reactions) (1 assignee)Java (1,234 forks)batch import
good first issue

Repository metrics

Stars
 (4,937 stars)
PR merge metrics
 (Avg merge 6d 7h) (186 merged PRs in 30d)

Description

We had a situation where defining controller.data.dir twice leads to the values being concatenated.

It would probably be better if an exception was thrown telling the user to only set the property once.

Contributor guide

Research direction
Identify where config properties are parsed, add a check for duplicate keys, and throw an exception with a clear message.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Java
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90