apache/pinot

Adding validation check to prevent creating two columns with different cases in schema

Open

#6,644 opened on Mar 4, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (1,234 forks)batch import
good first issuehelp wanted

Repository metrics

Stars
 (4,937 stars)
PR merge metrics
 (Avg merge 6d 7h) (186 merged PRs in 30d)

Description

Although pinot columns can be case-sensitive, I think we should still prevent the scenarios like this. This easily breaks the external case-insensitive integrations like Presto.

E.g. in the same schema, we shouldn't allow creating two columns like: memberId and MemberID.

Contributor guide

Research direction
Look at the schema validation code in the Pinot codebase, specifically where column definitions are parsed and stored, to add a check that prevents case insensitive duplicate column names.
Tech stack
java
Domain
backenddatabase
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaSQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60