apache/pinot

Controller Crashing - repetition of same config causing multi value setting

Open

#6,595 opened on Feb 19, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (1,234 forks)batch import
configurationgood first issue

Repository metrics

Stars
 (4,937 stars)
PR merge metrics
 (Avg merge 6d 7h) (186 merged PRs in 30d)

Description

I have following settings in controller config where validation.frequencyInSeconds is accidentally repeated. This is causing controller to crash as the value is derived as multi value. it will be better to take either last defined value or avoid this crash.

controller.realtime.segment.validation.frequencyInSeconds=300 controller.realtime.segment.validation.frequencyInSeconds=900 controller.broker.resource.validation.frequencyInSeconds=900

Error:

2021/02/18 14:46:44.389 ERROR [StartServiceManagerCommand] [main] Failed to start a Pinot [CONTROLLER] at 39.246 since launch java.lang.NumberFormatException: For input string: "[300, 900]" at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) ~[?:1.8.0_282] at java.lang.Integer.parseInt(Integer.java:580) ~[?:1.8.0_282]

Contributor guide

Research direction
Examine the configuration loading code to see how properties are read. The issue is that duplicate keys produce a list instead of a single value. The fix could be to use the last value or to validate uniqueness.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Java
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70