apache/pinot

Fix logging dependencies in pinot-spi

Open

#6,364 opened on Dec 17, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (1,234 forks)batch import
good first issuehelp wanted

Repository metrics

Stars
 (4,937 stars)
PR merge metrics
 (Avg merge 6d 7h) (186 merged PRs in 30d)

Description

pinot-spi’s pom has a dependency on log4j-slf4j-impl. I don’t think this is right - it should only depend on slf4j-api. Because of the current dependency, the pinot-java-client’s dependency on pinot-spi pulls in the logging implementation, which is not what you want because it means an external project using the client often needs to exclude those logging jars.

I'm guessing there are other components with a similar issue - only jars that are run from the command line should have dependencies on log4j-slf4j-impl, and include log4j2 configuration resources.

Contributor guide

Research direction
Move the log4j slf4j impl dependency from pinot spi's pom.xml to only the modules that are run from command line. Ensure that pinot java client and other library modules depend only on slf4j api. Check other components for similar issues.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaMaven
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70