apache/pinot

Improve controller rest api test

Open

#5,688 opened on Jul 12, 2020

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Java (1,234 forks)batch import
good first issuehelp wanted

Repository metrics

Stars
 (4,937 stars)
PR merge metrics
 (Avg merge 6d 7h) (186 merged PRs in 30d)

Description

Every end point test does the following

  • start zk
  • start controller -- run some tests -- tear down zk -- stop controller

This is inefficient and we can definitely run all the tests using just one integration test.

Contributor guide

Research direction
Examine the current test setup that starts ZooKeeper and controller per test. Design a single integration test class that initializes these once for all endpoints.
Tech stack
java
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaJUnit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60