apache/pinot

Refactor to eliminate duplicate code in Spark 2.x and 3.x Batch Ingestion

Open

#14271 opened on Oct 22, 2024

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Java (4,937 stars) (1,234 forks)batch import
cleanupgood first issueingestion

Description

Currently between spark 2.x and spark 3.x batch ingestion lot of code is duplicated other than SparkSegmentMetadataPushJobRunner class. This ticket is to refactor the code to eliminate the duplicate code without breaking the compatibility. Code changes required are to :

  • Abstract common functionality into shared methods/classes.
  • Separate version-specific details.
  • Ensure the resulting codebase is cleaner and easier to maintain.

Contributor guide

Tech stack
java
Domain
data
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaSpark batch ingestion in PinotUnderstanding of Spark 2.x vs 3.x differences
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Examine the code for Spark 2.x and 3.x batch ingestion, focusing on SparkSegmentMetadataPushJobRunner and related classes. Identify duplicated logic and design shared methods or parent classes to eliminate duplication while maintaining version specific behavior. Ensure backward compatibility by testing both versions.